Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(bootstrap 5): date field types, textareas and some fixes #772

Merged
merged 42 commits into from
Feb 20, 2024
Merged

refactor(bootstrap 5): date field types, textareas and some fixes #772

merged 42 commits into from
Feb 20, 2024

Conversation

theus77
Copy link
Member

@theus77 theus77 commented Feb 17, 2024

Q A
Bug fix? n
New feature? n
BC breaks? n
Deprecations? y
Fixed tickets? n
Documentation? n

@theus77
fix: no list if not iterable
5b19f98
@theus77
fix: not parsable date shows in red
eecd6ce
@theus77
fix: keep not parsable data
d30ec9e
@theus77
ref: DateTime documentation
0149984
@theus77
fix: test date is a date
cd828d2
@theus77
fix: keep wronf string on view revision
9b3b187
@theus77
fix: create invalid feedback message
5347743
@theus77
fix: create invalid feedback message
7f5f9f3
@theus77
chore: clean old code
dfbe151
@theus77
ref: html_classes
a6d00f7
@theus77
fix: avoid bootstrap to be loaded multiple time (popper was broken)
7bc2d75
@theus77
fix: dropdown-item
bbcfca9
@theus77
fix: has-error only for containers
18ea142
@theus77
ref: border in red for containers with errors
c93ae43
@theus77
fix: has-error only for containers
cba840a
@theus77
fix: autohide toasts
327d232
@theus77
ref: DateFieldType
eb03410
@theus77
ref: DateFieldType (is-invalid)
66f5938
@theus77
fix: not defined error
d484256
@theus77
chore: docs
453704a
@theus77
chore: deps
d186d78
@theus77
chore:
b18a3af
@theus77
chore: docs
b4cda3a
@theus77
feat: parseFormat
bf9afef
@theus77
feat: parseFormat
4487c06
@theus77
feat: parseFormat
0252123
@theus77
ref: date range
daaee7d
@theus77
ref: TimeFieldType
34332d1
@theus77
chore:
2ef6a0a
@theus77
chore: eslint
ef71f60
@theus77 theus77 marked this pull request as ready for review February 17, 2024 17:05
@theus77 theus77 requested a review from a team as a code owner February 17, 2024 17:05
@theus77 theus77 marked this pull request as draft February 19, 2024 17:47
@theus77 theus77 marked this pull request as ready for review February 19, 2024 20:09
@Davidmattei Davidmattei changed the title refactor(bootstrap 6): date field types, textareas and some fixes refactor(bootstrap 5): date field types, textareas and some fixes Feb 20, 2024
Davidmattei
Davidmattei approved these changes Feb 20, 2024
View reviewed changes
Copy link
Member

@Davidmattei Davidmattei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice! 👍

@Davidmattei Davidmattei merged commit 5429efe into ems-project:6.x Feb 20, 2024
4 checks passed
@theus77 theus77 deleted the ref/field-types branch March 5, 2024 04:25
@Davidmattei Davidmattei added this to the 6.0.0 milestone Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Davidmattei Davidmattei Davidmattei approved these changes

Assignees

@theus77 theus77

Labels
admin-ui-bundle core-bundle
Projects
Releases
Status: Done
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@theus77 @Davidmattei